Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account linking should only happen after 2fa when required #4174

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

zepatrik
Copy link
Member

Currently account linking happens after the first factor, even when the second factor is required for a session to be issued.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 83.82353% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (b4c453b) to head (27d96ba).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/flow/settings/handler.go 85.29% 5 Missing ⚠️
selfservice/flow/login/hook.go 85.71% 1 Missing and 3 partials ⚠️
session/manager_http.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4174      +/-   ##
==========================================
+ Coverage   78.57%   78.58%   +0.01%     
==========================================
  Files         379      379              
  Lines       27042    27052      +10     
==========================================
+ Hits        21249    21260      +11     
  Misses       4181     4181              
+ Partials     1612     1611       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@zepatrik zepatrik changed the title fix: account linking should only happen after 2fa fix: account linking should only happen after 2fa when required Oct 29, 2024
@zepatrik zepatrik merged commit 8e29b68 into master Oct 29, 2024
30 checks passed
@zepatrik zepatrik deleted the fix/login/account-linking-2fa branch October 29, 2024 09:30
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants