Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new prometheus metrics endpoint #672 #673

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

drwatsno
Copy link
Contributor

@drwatsno drwatsno commented Aug 25, 2020

Related issue

Resolves #672

Proposed changes

Implementation to support Prometheus in Kratos in addition to current telemetry

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2020

CLA assistant check
All committers have signed the CLA.

@aeneasr aeneasr requested review from zepatrik and aeneasr and removed request for zepatrik August 26, 2020 11:48
@aeneasr
Copy link
Member

aeneasr commented Aug 27, 2020

Really cool, thank you!

@aeneasr aeneasr merged commit 0f5c436 into ory:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement prometheus metrics endpoint
3 participants