Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync #214

Closed
wants to merge 5 commits into from
Closed

fix: sync #214

wants to merge 5 commits into from

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jul 20, 2023

fix: disable format in sync

This fixes the sync action by commenting out the format steps in the script. All the files are formatted anyway so I dont see why we would need it here and it breaks this sync action for a long time now due to missing ory-prettier-styles.
This is not the ideal solution, but I gave up trying to fix it in another way after some time...

@vinckr vinckr marked this pull request as ready for review July 20, 2023 11:09
@vinckr vinckr requested a review from aeneasr July 20, 2023 11:09
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will most likely cause the CI pipeline of dependent repos to fail, because the updated READMEs won’t be properly formatted. This then causes a bunch of other issues (eg manually going in every PR that is failing and doing make format + push).

Can you collect all failing repos (the pipeline seems to quit on the first error found) and the failure reasons? I can then take a look at those and try to fix them.

@vinckr vinckr marked this pull request as draft July 20, 2023 11:29
@vinckr
Copy link
Member Author

vinckr commented Jul 21, 2023

Can you collect all failing repos (the pipeline seems to quit on the first error found) and the failure reasons? I can then take a look at those and try to fix them.

the reason seems to be this, and failing the same for every repo:

npm WARN exec The following package was not found and will be installed: prettier@3.0.0
Error:  Invalid configuration for file "/tmp/tmp.aMusWb8Jtc/hydra/CODE_OF_CONDUCT.md":
Error:  Cannot find package 'ory-prettier-styles' imported from /tmp/tmp.aMusWb8Jtc/hydra/package.json
Error: Process completed with exit code 2.

all of the repos have

    "ory-prettier-styles": "1.3.0",
    "prettier": "2.7.1",

in their package.json, so not sure why it uses 3.0.0

@aeneasr
Copy link
Member

aeneasr commented Aug 3, 2023

Resolved by af28aff

@aeneasr aeneasr closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants