Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require verified address doesn't work for OIDC identities #246

Closed
3 of 6 tasks
jonas-jonas opened this issue Feb 16, 2023 · 8 comments
Closed
3 of 6 tasks

Require verified address doesn't work for OIDC identities #246

jonas-jonas opened this issue Feb 16, 2023 · 8 comments
Assignees
Labels
bug Something is not working.

Comments

@jonas-jonas
Copy link
Member

Preflight checklist

Describe the bug

When Require Verified Address for Login is activated, OIDC identities can still login, even if they have not verified their email address yet.

Reproducing the bug

  1. Enable Require Verified Address for Login
  2. Login using an unverified OIDC identity
  3. See the login go through

Relevant log output

No response

Relevant configuration

No response

Version

master

On which operating system are you observing this issue?

Ory Network

In which environment are you deploying?

Ory Network

Additional Context

https://ory-community.slack.com/archives/C02MR4DEEGH/p1676539388349389

@jonas-jonas jonas-jonas added the bug Something is not working. label Feb 16, 2023
@kmherrmann kmherrmann self-assigned this Jul 24, 2023
@jonas-jonas
Copy link
Member Author

I can still reproduce this. Taking a look now.

@jonas-jonas
Copy link
Member Author

Ah, the frontend only sets the hook for the password method. It doesn't for OIDC & Webauthn. So this is just a console issue.

@jonas-jonas
Copy link
Member Author

jonas-jonas commented Aug 10, 2023

Don't think it makes sense to fix this in the old UI, when we're going to rewrite this soon.

You can use the CLI to set the require_verified_address hook, in the meantime.

@aeneasr
Copy link
Member

aeneasr commented Aug 14, 2023

There is a more fundamental issue here too - the verified status is not carried over from the oidc provider. So basically every user is unverified when using social sign in in kratos.

@jonas-jonas
Copy link
Member Author

Related to ory/kratos#3424

@aeneasr
Copy link
Member

aeneasr commented Sep 25, 2023

That issue is now closed in Ory Kratos, is this here then also fixed?

@jonas-jonas
Copy link
Member Author

No, it's just related, but doesn't solve the issue.

But this is just a console issue, as right now we're only setting the require_verified_address hook for password login.

@aeneasr
Copy link
Member

aeneasr commented Dec 21, 2023

I confirmed that this bug is fixed on production. Closing!

@aeneasr aeneasr closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

3 participants