Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Within an OAuth flow the required verification flow does not show #320

Closed
3 of 6 tasks
Benehiko opened this issue Jul 6, 2023 · 7 comments
Closed
3 of 6 tasks

Within an OAuth flow the required verification flow does not show #320

Benehiko opened this issue Jul 6, 2023 · 7 comments
Assignees
Labels
bug Something is not working.

Comments

@Benehiko
Copy link

Benehiko commented Jul 6, 2023

Preflight checklist

Describe the bug

Within an OAuth flow within the AX the user is not shown the verification UI when the show_verification_ui hook is enabled. Instead it redirects back to the OAuth client.
https://www.ory.sh/docs/identities/sign-in/actions#show-verification-after-successful-registration

ory patch identity-config {project_id} \
  --add '/selfservice/flows/registration/after/password/hooks=[{"hook": "show_verification_ui"}]' \

Reproducing the bug

Ensure the show verification after successful registration is enabled.

  1. Create a OAuth login flow
  2. Switch to registration
  3. Register a new account
  4. The browser should now have returned the user back to the client

Relevant log output

No response

Relevant configuration

No response

Version

latest

On which operating system are you observing this issue?

Ory Network

In which environment are you deploying?

Ory Network

Additional Context

No response

@Benehiko Benehiko added the bug Something is not working. label Jul 6, 2023
@Benehiko
Copy link
Author

Benehiko commented Jul 6, 2023

Some more context, in ory/kratos we don't continue to the verification flow when there is a login_challenge in the URL as shown here
https://github.com/ory/kratos/blob/master/selfservice/flow/registration/hook.go#L249-L258

We probably need to continue to the verification flow with a return_to parameter of the current login URL.

@kmherrmann
Copy link

Is this the same as #246?

@Benehiko
Copy link
Author

Benehiko commented Jul 6, 2023

No this is a different issue, the issue above is when you are doing SSO and kratos does not redirect you to the verification screen.

@kmherrmann
Copy link

[Note: This is in progress now]

@hperl
Copy link

hperl commented Aug 12, 2023

Re-opened because the fix was not sufficient yet.

hperl added a commit to ory/kratos that referenced this issue Aug 12, 2023
@aeneasr aeneasr closed this as completed Aug 13, 2023
aeneasr pushed a commit to ory/kratos that referenced this issue Aug 13, 2023
@aeneasr
Copy link
Member

aeneasr commented Aug 14, 2023

@hperl this is now on prod right?

@hperl
Copy link

hperl commented Aug 14, 2023

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

4 participants