Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect to verification URL even if login_challenge is set #3412

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Aug 1, 2023

Related issue(s)

ory/network#320

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from Benehiko August 1, 2023 11:51
@hperl hperl self-assigned this Aug 1, 2023
Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #3412 (58bdc6d) into master (88237e2) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 88.23%.

❗ Current head 58bdc6d differs from pull request most recent head ca54f8c. Consider uploading reports for the commit ca54f8c to get more accurate results

@@            Coverage Diff             @@
##           master    #3412      +/-   ##
==========================================
- Coverage   78.02%   78.02%   -0.01%     
==========================================
  Files         327      327              
  Lines       21370    21379       +9     
==========================================
+ Hits        16673    16680       +7     
  Misses       3459     3459              
- Partials     1238     1240       +2     
Files Changed Coverage Δ
selfservice/flow/registration/hook.go 71.33% <81.81%> (+0.41%) ⬆️
identity/credentials.go 83.78% <100.00%> (ø)
selfservice/hook/show_verification_ui.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@hperl hperl merged commit cd9e6a0 into master Aug 2, 2023
28 checks passed
@hperl hperl deleted the hperl/oauth-show-verification-flow branch August 2, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants