-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release step in the CI #11
Conversation
fb1f023
to
d11ea15
Compare
d11ea15
to
5a6ba8c
Compare
c47a323
to
12139bd
Compare
Currently integration tests cannot be enabled due to the problem with running kind inside docker. |
source $BASH_ENV | ||
- setup_remote_docker | ||
- run: docker login --username "$DOCKER_USERNAME" --password "$DOCKER_PASSWORD" | ||
- run: curl -sL https://git.io/goreleaser | bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goreleaser must be configured: https://goreleaser.com/
Alternatively just docker build
and docker push
ps: The current docker file does not work with goreleaser, see: https://goreleaser.com/customization/#Docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pushed goreleaser yml config file, based on oathkeeper, however, I think that few things needs to be done on your side such as configuring GITHUB_TOKEN in the circleCI etc. Regarding dockerfile, I tool a look at docu and compared it with oathkeeper dockcerfile and didn't notice any missings piecies. Could you point me ?:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go releaser builds docker images in such a way where it first builds the binaries for all platform, then builds a docker image which simply copies the linux binary into the container. So there is no actual build step involved within the docker image itself.
Co-Authored-By: hackerman <3372410+aeneasr@users.noreply.github.com>
…hkeeper-k8s-controller into ci-cd-improvements
WORKDIR / | ||
COPY --from=builder /workspace/manager . | ||
ENTRYPOINT ["/manager"] | ||
FROM scratch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check if we need the distroless image from gcr or if scratch is enough!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scratch is enough :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - ready to merge?
I have added the env vars! |
2 additional steps added for release based on oathkeeper config