Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release step in the CI #11

Merged
merged 15 commits into from
Jul 29, 2019
Merged

Release step in the CI #11

merged 15 commits into from
Jul 29, 2019

Conversation

piotrmsc
Copy link
Collaborator

@piotrmsc piotrmsc commented Jul 24, 2019

2 additional steps added for release based on oathkeeper config

@piotrmsc piotrmsc marked this pull request as ready for review July 24, 2019 18:40
@piotrmsc piotrmsc force-pushed the ci-cd-improvements branch 2 times, most recently from fb1f023 to d11ea15 Compare July 24, 2019 19:13
@piotrmsc piotrmsc force-pushed the ci-cd-improvements branch from d11ea15 to 5a6ba8c Compare July 26, 2019 06:24
@piotrmsc piotrmsc changed the title Initial changes with release pipeline Integration step and release step in the CI Jul 26, 2019
@piotrmsc piotrmsc force-pushed the ci-cd-improvements branch from c47a323 to 12139bd Compare July 26, 2019 09:21
@piotrmsc piotrmsc changed the title Integration step and release step in the CI Release step in the CI Jul 26, 2019
@piotrmsc
Copy link
Collaborator Author

Currently integration tests cannot be enabled due to the problem with running kind inside docker.
We will think of the workaround, current possibilities : run kind directly on a machine or get rid of kind and use binaries of apiserver.

Makefile Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
source $BASH_ENV
- setup_remote_docker
- run: docker login --username "$DOCKER_USERNAME" --password "$DOCKER_PASSWORD"
- run: curl -sL https://git.io/goreleaser | bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goreleaser must be configured: https://goreleaser.com/

Alternatively just docker build and docker push

ps: The current docker file does not work with goreleaser, see: https://goreleaser.com/customization/#Docker

Copy link
Collaborator Author

@piotrmsc piotrmsc Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed goreleaser yml config file, based on oathkeeper, however, I think that few things needs to be done on your side such as configuring GITHUB_TOKEN in the circleCI etc. Regarding dockerfile, I tool a look at docu and compared it with oathkeeper dockcerfile and didn't notice any missings piecies. Could you point me ?:)

Copy link
Member

@aeneasr aeneasr Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go releaser builds docker images in such a way where it first builds the binaries for all platform, then builds a docker image which simply copies the linux binary into the container. So there is no actual build step involved within the docker image itself.

WORKDIR /
COPY --from=builder /workspace/manager .
ENTRYPOINT ["/manager"]
FROM scratch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if we need the distroless image from gcr or if scratch is enough!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scratch is enough :)

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - ready to merge?

@aeneasr
Copy link
Member

aeneasr commented Jul 29, 2019

I have added the env vars!

@aeneasr aeneasr merged commit 190797f into ory:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants