Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support gzipped responses in check session URLs #836

Closed
aeneasr opened this issue Sep 27, 2021 · 4 comments
Closed

Support gzipped responses in check session URLs #836

aeneasr opened this issue Sep 27, 2021 · 4 comments
Labels
stale Feedback from one or more authors is required to proceed.

Comments

@aeneasr
Copy link
Member

aeneasr commented Sep 27, 2021

Describe the bug

See #835

@aeneasr aeneasr added the bug Something is not working. label Sep 27, 2021
@dreverri
Copy link

dreverri commented Sep 28, 2021

If a request manually sets the Accept-Encoding header the transport will not automatically decode the response.

https://pkg.go.dev/net/http#Transport.DisableCompression

Currently, it looks like oathkeeper copies all the headers from the original request so if the original request has the Accept-Encoding header the body will not decompressed.

for k, v := range r.Header {

@aeneasr aeneasr closed this as completed Oct 3, 2021
@aeneasr aeneasr reopened this Oct 3, 2021
@aeneasr
Copy link
Member Author

aeneasr commented Oct 3, 2021

Ah, I see, that makes sense!

@till
Copy link

till commented Feb 9, 2022

@aeneasr PR coming soon. We somehow hit that.

till added a commit to hostwithquantum/ory-oathkeeper-fork that referenced this issue Feb 9, 2022
till added a commit to hostwithquantum/ory-oathkeeper-fork that referenced this issue Feb 10, 2022
till added a commit to hostwithquantum/ory-oathkeeper-fork that referenced this issue Jun 23, 2022
till added a commit to hostwithquantum/ory-oathkeeper-fork that referenced this issue Jun 23, 2022
@kmherrmann kmherrmann removed the bug Something is not working. label Jun 19, 2023
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

4 participants