Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update oathkeeper json schema #1051

Merged

Conversation

daviddelucca
Copy link
Contributor

Update schema to support opentelemetry. Related to PR ory/x#656

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #1051 (c9183e5) into refactor/mutator-tracing (fed7446) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##           refactor/mutator-tracing    #1051   +/-   ##
=========================================================
  Coverage                     78.14%   78.14%           
=========================================================
  Files                            83       83           
  Lines                          3976     3976           
=========================================================
  Hits                           3107     3107           
  Misses                          591      591           
  Partials                        278      278           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alnr alnr self-assigned this Jan 6, 2023
@alnr alnr merged commit 9ec9bd6 into ory:refactor/mutator-tracing Jan 6, 2023
@vinckr
Copy link
Member

vinckr commented Jan 7, 2023

Hello @daviddelucca
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants