-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add delegate
authenticator
#1153
Open
yunier-rojas
wants to merge
3
commits into
ory:master
Choose a base branch
from
yunier-rojas:feat-delegate-authenticator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem Summary This merge request addresses issue !669 surrounding the behavior of the "noop" authentication method, which underwent changes in commit 6f8ab4f. Reverting these changes to restore the previous behavior is challenging due to the potential for breaking existing systems. To mitigate this risk, we propose implementing a new authenticator named "delegate" to replicate the original behavior of the "noop" method. ## Ideal Solution To address this issue, our proposed solution is to implement a new authenticator named "delegate" that replicates the original behavior of the "noop" method. This approach ensures that existing systems in production remain stable and unaffected by changes, while also providing users who prefer the old behavior with an option to utilize it. By introducing the "delegate" authenticator, we mitigate the risk of breaking changes while offering flexibility to users who require the previous behavior. ## Changes Proposed 1. **New Authenticator Module**: This MR adds a new authenticator module named "delegate" to replicate the original behavior of the "noop" method. 3. **Integration Tests**: Integration tests will be added to validate the functionality of the "delegate" authenticator, ensuring compatibility and reliability. 4. **Documentation Updates**: Documentation will be updated to include details about the new "delegate" authenticator, its configuration options, and usage examples. ## Related Issues ory#1152 ory#669 closes 1152
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
+ Coverage 77.90% 77.98% +0.07%
==========================================
Files 80 81 +1
Lines 3929 3942 +13
==========================================
+ Hits 3061 3074 +13
Misses 595 595
Partials 273 273 ☔ View full report in Codecov by Sentry. |
yunier-rojas
added a commit
to yunier-rojas/ory-docs
that referenced
this pull request
Mar 7, 2024
ory/oathkeeper#1153 implements a new authenticator to allow authn/authz delegation to upstream services.
6 tasks
yunier-rojas
added a commit
to yunier-rojas/ory-docs
that referenced
this pull request
Mar 7, 2024
ory/oathkeeper#1153 implements a new authenticator to allow authn/authz delegation to upstream services. Relates to ory/oathkeeper#1152
yunier-rojas
added a commit
to yunier-rojas/ory-docs
that referenced
this pull request
Mar 7, 2024
ory/oathkeeper#1153 implements a new authenticator to allow authn/authz delegation to upstream services. Relates to ory/oathkeeper#1152
yunier-rojas
added a commit
to yunier-rojas/ory-docs
that referenced
this pull request
Mar 7, 2024
ory/oathkeeper#1153 implements a new authenticator to allow authn/authz delegation to upstream services. Relates to ory/oathkeeper#1152
yunier-rojas
added a commit
to yunier-rojas/ory-docs
that referenced
this pull request
Mar 7, 2024
ory/oathkeeper#1153 implements a new authenticator to allow authn/authz delegation to upstream services. Relates to ory/oathkeeper#1152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Summary
This merge request addresses issue #669 surrounding the behavior of the "noop" authentication method, which underwent changes in commit 6f8ab4f. Reverting these changes to restore the previous behavior is challenging due to the potential for breaking existing systems. To mitigate this risk, we propose implementing a new authenticator named "delegate" to replicate the original behavior of the "noop" method.
Ideal Solution
To address this issue, our proposed solution is to implement a new authenticator named "delegate" that replicates the original behavior of the "noop" method. This approach ensures that existing systems in production remain stable and unaffected by changes, while also providing users who prefer the old behavior with an option to utilize it. By introducing the "delegate" authenticator, we mitigate the risk of breaking changes while offering flexibility to users who require the previous behavior.
Changes Proposed
New Authenticator Module: This MR adds a new authenticator module named "delegate" to replicate the original behavior of the "noop" method.
Integration Tests: Integration tests will be added to validate the functionality of the "delegate" authenticator, ensuring compatibility and reliability.
Documentation Updates: Documentation will be updated to include details about the new "delegate" authenticator, its configuration options, and usage examples.
Related Issues
#1152
#669
closes 1152
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments