Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect title & descriptions SDK #153

Closed
6 tasks done
vinckr opened this issue Feb 28, 2022 · 0 comments · Fixed by ory/hydra#3014
Closed
6 tasks done

Incorrect title & descriptions SDK #153

vinckr opened this issue Feb 28, 2022 · 0 comments · Fixed by ory/hydra#3014
Assignees
Labels
bug Something is not working.

Comments

@vinckr
Copy link
Member

vinckr commented Feb 28, 2022

Preflight checklist

Describe the bug

Something is broken in the SDK schema automation and the Oathkeeper title & descriptions gets copied into Hydra, e.g. for the .NET client:
https://github.com/ory/sdk/blob/master/clients/hydra/dotnet/src/Ory.Hydra.Client/Api/MetadataApi.cs#L2
Go Client
https://github.com/ory/hydra-client-go/blame/a98bdcd048644468cfd0bd77bb9986e958967011/api/openapi.yaml#L9
etc.

It also leads to quirks like the docs saying Oathkeeper API reference
https://www.ory.sh/docs/keto/reference/rest-api

(It is broken for all that got recently updated, so Keto as well)

Could it be the something going wrong with ${PROJECT_UCF} in the generate script:

(sed "s/${VERSION}/${RAW_VERSION}"'"\ndescription = "SDK Client for Ory '"${PROJECT_UCF}"'"\ndocumentation = "https:\/\/www.ory.sh\/'"${PROJECT}"'\/docs\/sdk"\nhomepage = "https:\/\/www.ory.sh"\nlicense = "Apache-2.0/g' < "${file}") > tmp.$$.rb && mv tmp.$$.rb "${file}"

?

Reproducing the bug

Go to e.g.
https://github.com/ory/sdk/blob/master/clients/hydra/dotnet/src/Ory.Hydra.Client/Api/MetadataApi.cs#L2

or

https://www.ory.sh/docs/keto/reference/rest-api

Relevant log output

No response

Relevant configuration

No response

Version

u

On which operating system are you observing this issue?

Other

In which environment are you deploying?

Other

Additional Context

No response

@vinckr vinckr added the bug Something is not working. label Feb 28, 2022
@vinckr vinckr changed the title Incorrect title & description Ory Hydra SDK Incorrect title & descriptions SDK Feb 28, 2022
@aeneasr aeneasr self-assigned this Feb 28, 2022
aeneasr added a commit to ory/hydra that referenced this issue Feb 28, 2022
aeneasr added a commit to ory/hydra that referenced this issue Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants