Feature/password strength meter #101
Conversation
There was a problem hiding this comment.
Thank you - the passwordmeter is exclusive to ORY Kratos and not used anywhere else. So this probably belongs into ory/kratos instead.
Also, please run tests (go test ./...) and linting (make lint) before pushing up a new PR, or use the "Draft PR" GitHub feature to indicate that you're still working on this.
| // Responses: | ||
| // 200: passwordStrength | ||
| // 500: genericError | ||
| func (h *Handler) PasswordStrength(rw http.ResponseWriter, r *http.Request, _ httprouter.Params) { |
There was a problem hiding this comment.
This function doesn't do anything, is that on purpose?
passwordstrengthmeter/handler.go
Outdated
| ) | ||
|
|
||
| // RoutesToObserve returns a string of all the available routes of this module. | ||
| func RoutesToObserve() []string { |
There was a problem hiding this comment.
This is nowhere used. Please don't just copy source files from one destination to another and replace the names.
| alive := errors.New("not alive") | ||
| handler := &Handler{ | ||
| H: herodot.NewJSONWriter(nil), | ||
| VersionString: "test version", |
| ) | ||
|
|
||
| func TestPasswordStrengthMeter(t *testing.T) { | ||
| alive := errors.New("not alive") |
There was a problem hiding this comment.
This is a copy of the health test, but we need a different test suite here.
|
@aeneasr do you want it in kratos or i put it in ory/x |
…/x into feature/passwordStrengthMeter
|
@evalsocket this belongs into kratos :) |
Related issue
Proposed changes
Feature request in ory/kratos i.e. Add password strength meter. It can be used across the ory ecosystem
Checklist
vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
Further comments