Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't watch for shutdown signal on profiling #28

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

kminehart
Copy link
Contributor

Signed-off-by: Kevin Minehart kmineh0151@gmail.com

Related issue

ory/hydra#1061

Proposed changes

profilex functions were watching for shutdown signals, causing the file writers to never Close.

This change disables watching for shutdown signals in the profile package.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)

Further comments

I didn't see a very good place to write tests for this type of change. If you have any suggestions, then please let me know. :)

Signed-off-by: Kevin Minehart <kmineh0151@gmail.com>
@aeneasr aeneasr merged commit e8fce87 into ory:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants