Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Jaeger] Add maxTagValueLength for the feature request #2447 #327

Merged
merged 1 commit into from
Apr 21, 2021
Merged

feat: [Jaeger] Add maxTagValueLength for the feature request #2447 #327

merged 1 commit into from
Apr 21, 2021

Conversation

kobayashilin
Copy link
Contributor

Related issue

ory/hydra#2447

Proposed changes

Make the maxTagValueLength configurable for jaeger

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

The issue 2447 need another change on ory/hydra repository to apply it

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2021

CLA assistant check
All committers have signed the CLA.

@kobayashilin kobayashilin changed the title [Jaeger] Add maxTagValueLength for the feature request #2447 feat: [Jaeger] Add maxTagValueLength for the feature request #2447 Apr 21, 2021
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution!

@aeneasr aeneasr merged commit 074a9e4 into ory:master Apr 21, 2021
@kobayashilin kobayashilin deleted the feature-jaeger-maxtagvaluelength branch April 22, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants