Add web UI controls to select more builds in group_overview #804
Conversation
|
I don't like this 'limited to 3' - this appears to me like a feature to ease test writing, but not necessarily adding anything useful for the user |
|
We have the same information for previous results. I thought it would be useful e.g. in the case when there are only 2 builds at all but it says "limited to 10" so users should understand it wouldn't help to click "400 builds". |
okurz
force-pushed
the
feature/more_builds_gui
branch
from
137a190 to
3da2b1c
Compare
|
Changes Unknown when pulling 3da2b1c on okurz:feature/more_builds_gui into * on os-autoinst:master*. |
|
this is very easy to find out yourself, you don't need the UI to babysit you. You don't put "(this is the group name)" behind Tumbleweed just in case someone confuses it with the real Tumbleweed. |
|
It's not easy to find out because if the URL is |
|
then make 10 a valid option in your list and highlight the currently selected option - once again pointing you to the solution used everywhere else in our application: https://datatables.net/examples/styling/bootstrap.html |
|
you mean I should add a pull down menue and dynamically reload the page with different query parameters based on selection within the pull down menue? What we used "everywhere else" is to control the display of the already loaded table entries, isn't it? |
|
Noone stops you making it AJAX in a 2nd step |
|
On Monday 01 August 2016 04:10:16 Stephan Kulow wrote:
No one stops me but my lack of ajax knowledge certainly slows me down |
|
That's why they call you Mister Fahrenheit |
|
how very kind of you. But I wanted to keep the page clean and easy just as for previous results. Isn't that where modern page design goes and that's why we have mojo? Generate pages rather than loading complicate ones that try to do everything dynamically? |
|
No, the modern people combine nodejs with https://angularjs.org/ :) |
|
oh, and also by using direct links I am saving users one click. |
|
that will sum up easily to 2-3 seconds a life time for advanced users :) |
okurz
force-pushed
the
feature/more_builds_gui
branch
from
3da2b1c to
3d3f6f3
Compare
|
Old screenshot: updated to use the same approach as in #811: Show current limit in bold as part of the selection list |
| @@ -242,6 +242,20 @@ sub register { | |||
|
|
|||
| return $c->tag('span', title => $text, sub { substr($text, 0, $length - 4) . " ..." }); | |||
| }); | |||
|
|
|||
| $app->helper( | |||
| #%= b join(' / ', map { link_to($_ == $limit_builds ? "<b>$_</b>" : $_ => url_with->query(time_limit_days => 1000, limit_builds => $_)) } (10, 20, 50, 100, 400)) | |||
The query parameter 'limit_builds' allows to show more than the default 10 builds on demand. Just like we have for configuring previous results, the current commit adds web UI selections to reload the same page with higher number of builds on demand. For this, the limit of days is increased to show more builds but still limited by the selected number.
okurz
force-pushed
the
feature/more_builds_gui
branch
from
3d3f6f3 to
a9ac764
Compare
|
updated:
|
The query parameter 'limit_builds' allows to show more than the default 10
builds on demand. Just like we have for configuring previous results, the
current commit adds web UI selections to reload the same page with
higher number of builds on demand. For this, the limit of days is increased
to show more builds but still limited by the selected number.
Example screenshot:
