Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse microos/journal_check in JeOS testing 2nd attempt #12812

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Reuse microos/journal_check in JeOS testing 2nd attempt #12812

merged 3 commits into from
Jul 8, 2021

Conversation

mloviska
Copy link
Contributor

@mloviska mloviska commented Jun 29, 2021 •
edited
Loading

@mloviska mloviska force-pushed the log-warnings-2nd-attemtp branch 5 times, most recently from c516423 to 2a7384b Compare July 2, 2021 14:50
@jlausuch jlausuch self-requested a review July 6, 2021 08:16
@mloviska mloviska force-pushed the log-warnings-2nd-attemtp branch 7 times, most recently from adbc404 to c0b2bfa Compare July 8, 2021 07:34
@mloviska mloviska changed the title Log warnings 2nd attemtp Reuse microos/journal_check in JeOS testing 2nd attempt Jul 8, 2021
@mloviska mloviska marked this pull request as ready for review July 8, 2021 08:12
@mloviska mloviska requested a review from Vogtinator July 8, 2021 08:12
@mloviska mloviska force-pushed the log-warnings-2nd-attemtp branch from c0b2bfa to fd7590f Compare July 8, 2021 08:15
@mloviska mloviska added the Ready Ready for review label Jul 8, 2021
@Vogtinator
Copy link
Member

The commits aren't just plain reverts, so the subject+description need to be edited IMO.

The TW JeOS test now fails with Jul 08 07:42:37.643071 localhost wicked[755]: DHCPv4 not supported on 'lo', never seen that before...

@mloviska mloviska force-pushed the log-warnings-2nd-attemtp branch from fd7590f to cbb57c6 Compare July 8, 2021 11:23
@mloviska
Copy link
Contributor Author

mloviska commented Jul 8, 2021

The commits aren't just plain reverts, so the subject+description need to be edited IMO.

The TW JeOS test now fails with Jul 08 07:42:37.643071 localhost wicked[755]: DHCPv4 not supported on 'lo', never seen that before...

Good point, I have changed only the first commit message, as the microos/libzypp_config.pm is basically untouched. Let me check the TW failure.

@mloviska
Copy link
Contributor Author

mloviska commented Jul 8, 2021

The commits aren't just plain reverts, so the subject+description need to be edited IMO.

The TW JeOS test now fails with Jul 08 07:42:37.643071 localhost wicked[755]: DHCPv4 not supported on 'lo', never seen that before...

Seems like it is somehow triggered by jeos-firstboot. The message itself does not appear after reboot.

@Vogtinator
Copy link
Member

The commits aren't just plain reverts, so the subject+description need to be edited IMO.
The TW JeOS test now fails with Jul 08 07:42:37.643071 localhost wicked[755]: DHCPv4 not supported on 'lo', never seen that before...

Seems like it is somehow triggered by jeos-firstboot. The message itself does not appear after reboot.

Indeed, jeos-firstboot also attempts DHCP on lo. I'll send a PR, that can be used as bugref as well.

@Vogtinator
Copy link
Member

The commits aren't just plain reverts, so the subject+description need to be edited IMO.
The TW JeOS test now fails with Jul 08 07:42:37.643071 localhost wicked[755]: DHCPv4 not supported on 'lo', never seen that before...

Seems like it is somehow triggered by jeos-firstboot. The message itself does not appear after reboot.

Indeed, jeos-firstboot also attempts DHCP on lo. I'll send a PR, that can be used as bugref as well.

openSUSE/jeos-firstboot#83

mloviska added 2 commits July 8, 2021 15:35
@mloviska
Reuse microos/journal_check in JeOS testing
5376df8 
Detect new log messages in JeOS images. Compare found log
messages of journal's priority error ( by default ) or specified by the
user in `JOURNAL_LOG_LEVEL` against bug reference file stored in
`data/journal_check/`.

- Related ticket: [JeOS's Warnings in log](https://progress.opensuse.org/issues/93267)
@mloviska
Revert "Revert "Adapt zypp.conf file check for JeOS""
b0b8e29 
This reverts commit a0cdf37.
@mloviska mloviska force-pushed the log-warnings-2nd-attemtp branch from cbb57c6 to b0b8e29 Compare July 8, 2021 13:36
@mloviska
Copy link
Contributor Author

mloviska commented Jul 8, 2021

The commits aren't just plain reverts, so the subject+description need to be edited IMO.
The TW JeOS test now fails with Jul 08 07:42:37.643071 localhost wicked[755]: DHCPv4 not supported on 'lo', never seen that before...

Seems like it is somehow triggered by jeos-firstboot. The message itself does not appear after reboot.

Indeed, jeos-firstboot also attempts DHCP on lo. I'll send a PR, that can be used as bugref as well.

openSUSE/jeos-firstboot#83

Thanks, VR:
opensuse-Tumbleweed-JeOS-for-kvm-and-xen-x86_64-Build20210706-log-warnings@uefi_virtio-2G

@mloviska @Vogtinator
Update data/journal_check/bug_refs.json
9ca1230 
Co-authored-by: Fabian Vogt <fabian@ritter-vogt.de>
@jlausuch
Copy link
Contributor

jlausuch commented Jul 8, 2021

Do we want to keep journal check before all console tests?

@mloviska
Copy link
Contributor Author

mloviska commented Jul 8, 2021

Do we want to keep journal check before all console tests?

I am aware that it is not really following the requirements set by Vincent to catch even package messages as came from the salt etc. But as of now, with log level priority defined to warning it feels kinda overwhelming already. It would be nice to have an easier start 🤪

jlausuch
jlausuch approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@jlausuch jlausuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlausuch jlausuch merged commit 8719e36 into os-autoinst:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlausuch jlausuch jlausuch approved these changes

@Vogtinator Vogtinator Vogtinator approved these changes

Assignees
No one assigned
Labels
Ready Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mloviska @Vogtinator @jlausuch