Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align qesap regression LTSS to HanaSR #20796

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

mpagot
Copy link
Contributor

@mpagot mpagot commented Dec 12, 2024

Change the qesap regression implementation of LTSS registration to be more aligned to the one implemented for HanaSR. Use more similar variables, use functions from the registration library. Allow LTSS to be enabled in all conf.yaml.

Related ticket: https://jira.suse.com/browse/TEAM-9839

Improved version of #20624

Verification run:

https://openqaworker15.qa.suse.cz/tests/overview?distri=sle&version=12-SP5&build=mpagot_VR&groupid=40

BYOS

Azure

http://openqaworker15.qa.suse.cz/tests/306482 LTSS-ES register.yaml command line is correctly composed in http://openqaworker15.qa.suse.cz/tests/306482/file/configure-qesap_azure.yaml -e use_suseconnect=true -e sles_modules='[{"key":"SLES-LTSS-Extended-Security/12.5/x86_64","value":"********"}]' and registration is ok in http://openqaworker15.qa.suse.cz/tests/306482/logfile?filename=deploy-ansible.registration.log.txt 🟢

http://openqaworker15.qa.suse.cz/tests/306483 no LTSS 🟢

Aws

http://openqaworker15.qa.suse.cz/tests/306486 no LTSS 🟢
http://openqaworker15.qa.suse.cz/tests/306487 LTSS 🟢

Gcp

http://openqaworker15.qa.suse.cz/tests/306490 no LTSS 🟢 registration is fine, no LTSS module, failure is later in the cluster status (native fencing)
http://openqaworker15.qa.suse.cz/tests/306491 LTSS 🟢 registration is fine, LTSS module enabled, failure is later in the cluster status (native fencing)

PAYG

Azure

http://openqaworker15.qa.suse.cz/tests/306501 no LTSS 🟢
http://openqaworker15.qa.suse.cz/tests/306500 🔴 failure in LTSS registration, known issue, not test issue

Aws

http://openqaworker15.qa.suse.cz/tests/306498 no LTSS 🟢
http://openqaworker15.qa.suse.cz/tests/306499 LTSS registration is fine but later zypper ref timeout
https://openqaworker15.qa.suse.cz/tests/306567 LTSS registration is fine but later zypper ref timeout

Gcp

http://openqaworker15.qa.suse.cz/tests/306569 no LTSS 🟢 registration is fine, LTSS module enabled, failure is later in the cluster status (native fencing)
http://openqaworker15.qa.suse.cz/tests/306570 LTSS 🔴 fails in zypper ref

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

tests/sles4sap/qesapdeployment/configure.pm Outdated Show resolved Hide resolved
tests/sles4sap/qesapdeployment/configure.pm Outdated Show resolved Hide resolved
tests/sles4sap/qesapdeployment/configure.pm Outdated Show resolved Hide resolved
lib/qesapdeployment.pm Outdated Show resolved Hide resolved
lib/qesapdeployment.pm Outdated Show resolved Hide resolved
lib/qesapdeployment.pm Outdated Show resolved Hide resolved
tests/sles4sap/qesapdeployment/configure.pm Outdated Show resolved Hide resolved
@mpagot mpagot force-pushed the qesap_ltss_next branch 2 times, most recently from d28c9e8 to bf57a8b Compare December 12, 2024 16:55
Change the qesap regression implementation of LTSS registration to be
more aligned to the one implemented for HanaSR. Use more similar
variables, use functions from the registration library. Allow LTSS to be
enabled in all conf.yaml.
Copy link
Contributor

@Amrysliu Amrysliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"\"key\":\"$ltss_args[0]\"," .
"\"value\":\"$ltss_args[1]\"}]'";
}
push @reg_args, qesap_ansible_reg_module(reg => $args{ltss}) if ($args{ltss});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that args{ltss} is still used, shouldn't it be kept in the docstring?

Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpagot mpagot merged commit a988190 into os-autoinst:master Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants