Add support for more value types in TrinoBatchInsert #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems needed by Trino:
Works:
('Exelon Corp.', 'Commonwealth Edison Co.', 32, TIMESTAMP '2015-01-01 00:00:00', 'nuclear', 'non_fuel_operation_expenses', 'electric expenses', 0.0, 0.0)
Fails:
('Exelon Corp.', 'Commonwealth Edison Co.', 32, 2015-01-01 00:00:00, 'nuclear', 'non_fuel_operation_expenses', 'electric expenses', 0.0, 0.0)
Signed-off-by: MichaelTiemannOSC <mtiemann@os-climate.org>
MichaelTiemannOSC
force-pushed
the
fix-timestamp
branch
from
c00316a to
aeef21c
Compare
|
I reviewed the log but don't understand what is causing the failure. The test code I see looks innocuous. |
You have to pay the formatter troll a coin. Use |
Use isort to put dependencies in proper order. Signed-off-by: MichaelTiemannOSC <mtiemann@os-climate.org>
MichaelTiemannOSC
force-pushed
the
fix-timestamp
branch
from
ba17741 to
71f7862
Compare
Trino prefers to see NaN as nan() Signed-off-by: MichaelTiemannOSC <mtiemann@os-climate.org>
And also handle things that are math.isnan correctly. Signed-off-by: MichaelTiemannOSC <mtiemann@os-climate.org>
Corrected. Signed-off-by: MichaelTiemannOSC <mtiemann@os-climate.org>
|
We need to add timestamp and NaN values to unit tests, to verify they are being output in the way you expect |
Support non-finite floats, in case needed. The SQL spelling of nan, inf, and -inf is different. Signed-off-by: MichaelTiemannOSC <mtiemann@os-climate.org>
It's "boolean" in SQL-land. Signed-off-by: MichaelTiemannOSC <mtiemann@os-climate.org>
erikerlandson
changed the title
erikerlandson
added a commit
that referenced
this pull request
Mar 30, 2022
Signed-off-by: Erik Erlandson <eerlands@redhat.com>
Merged
erikerlandson
added a commit
that referenced
this pull request
Mar 31, 2022
erikerlandson
added a commit
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems needed by Trino:
Works:
('Exelon Corp.', 'Commonwealth Edison Co.', 32, TIMESTAMP '2015-01-01 00:00:00', 'nuclear', 'non_fuel_operation_expenses', 'electric expenses', 0.0, 0.0)
Fails:
('Exelon Corp.', 'Commonwealth Edison Co.', 32, 2015-01-01 00:00:00, 'nuclear', 'non_fuel_operation_expenses', 'electric expenses', 0.0, 0.0)