Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support I_SERDES CLK_OUT #1680

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Support I_SERDES CLK_OUT #1680

merged 9 commits into from
Aug 26, 2024

Conversation

chungshien-chai
Copy link
Collaborator

@chungshien-chai chungshien-chai commented Aug 21, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

Pending on RIC API update

Changes:

  1. Support CORE clock based on the port connection (revert auto-determination)
  2. Support I_SERDES CLK_OUT
  3. Strict checking on pin utilization after considering bidirectional

What does this pull request change?

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@chungshien-chai chungshien-chai marked this pull request as draft August 21, 2024 22:54
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 14.81%. Comparing base (eb56f3f) to head (21725af).
Report is 1 commits behind head on main.

Files Patch % Lines
src/Configuration/ModelConfig/ModelConfig_IO.cpp 90.32% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
- Coverage   14.94%   14.81%   -0.13%     
==========================================
  Files         480      480              
  Lines       63993    63842     -151     
  Branches    26217    26166      -51     
==========================================
- Hits         9564     9459     -105     
- Misses      53161    53165       +4     
+ Partials     1268     1218      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chungshien-chai chungshien-chai changed the title Foedag io Support I_SERDES CLK_OUT Aug 21, 2024
@chungshien-chai chungshien-chai marked this pull request as ready for review August 26, 2024 22:49
@alaindargelas alaindargelas merged commit f42d454 into main Aug 26, 2024
33 of 35 checks passed
@alaindargelas alaindargelas deleted the foedag-io branch August 26, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants