Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extractor generated CLK pin XML if possible #1711

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

chungshien-chai
Copy link
Collaborator

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@chungshien-chai chungshien-chai marked this pull request as draft October 1, 2024 04:22
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 14.46%. Comparing base (0e8942a) to head (2fd11d6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Compiler/CompilerOpenFPGA.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
- Coverage   14.46%   14.46%   -0.01%     
==========================================
  Files         478      478              
  Lines       63819    63822       +3     
  Branches    26151    26143       -8     
==========================================
  Hits         9230     9230              
- Misses      53350    53352       +2     
- Partials     1239     1240       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chungshien-chai chungshien-chai marked this pull request as ready for review October 1, 2024 18:05
@alaindargelas alaindargelas merged commit e1992e6 into main Oct 1, 2024
34 of 35 checks passed
@alaindargelas alaindargelas deleted the foedag-clk-pin branch October 1, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants