Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fifo generator minor fix #2055

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Fifo generator minor fix #2055

merged 2 commits into from
Oct 11, 2024

Conversation

bilal458
Copy link
Contributor

@bilal458 bilal458 commented Oct 11, 2024 •
edited
Loading

Motivate of the pull request

  • To address an existing issue. If so, please add GH or Jira ID here:

Which submodule does this change impact ?

  • IP_Catalog

What does this pull request change?

Verified that the following tests passed locally before PR was created.

@ravikiranchollangi
Copy link
Contributor

@bilal458 why not run the tcl tests ?

@bilal458
Copy link
Contributor Author

Our change doesn't impact anything. But i will run in the future.

@ravikiranchollangi
Copy link
Contributor

Our change doesn't impact anything. But i will run in the future.

Are you sure ? These are integration tests.

@ravikiranchollangi ravikiranchollangi merged commit 5609027 into main Oct 11, 2024
43 checks passed
@ravikiranchollangi ravikiranchollangi deleted the 11_october branch October 11, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravikiranchollangi ravikiranchollangi Awaiting requested review from ravikiranchollangi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilal458 @ravikiranchollangi