VFS Archive support #67
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also yes, as the CI pointed out, I didn't update the lockfile yet either. |
|
I don't know why the CI linter doesn't like my switch statement but I don't see anything wrong with it, the indentation looks correct to me. @andersevenrud could you weigh in when you get a chance? I could change the |
Feel free to do so. I don't think I have a switch statement in the codebase anywhere else, so this has never popped up for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to close out #64, pending the merge of os-js/osjs-gui#40 and os-js/osjs-filemanager-application#41. Will result in the resolution of os-js/osjs-filemanager-application#39 as well.
Opening as a draft because there are still a few slight modifications that I want to make, most notably a
try/catchfor thecompressaction that deletes the ZIP file on an error rather than leaving behind a corrupt artifact. Also there is one test (noted with a TODO) that I implemented that still doesn't work and that I have been unable to figure out, so some help with that would be appreciated.