Skip to content

Gather code repositories into the API repository #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2025

Conversation

tuj
Copy link
Contributor

@tuj tuj commented Jun 25, 2025

Link to issue

#249

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/4565

Description

Gathered code repositories into the API repository

TODOs handled

  • Remove remote components
  • Better config handling through Symfony
  • Fix hmr setup
  • Release.json
  • Unify changelogs
  • Setup admin tests in playwright.

Breaking changes

  • External templates cannot be loaded anymore, since remote-components has been removed.
  • All config.json files are not used anymore. All configuration should be set through .env
  • All paths to the API are hardcoded in the client and admin.
  • The clients use the same release.json file.
  • Js tests should be run on production build files.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@tuj tuj added this to the 3.0.0 milestone Jun 25, 2025
@tuj tuj requested review from turegjorup and sinejespersen June 25, 2025 10:35
@tuj tuj self-assigned this Jun 25, 2025
@tuj tuj added the enhancement New feature or request label Jun 25, 2025
Copy link
Contributor

@turegjorup turegjorup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the controllers (and template files) should be namespaced as

/Controller/Admin
/Controller/Api
/Controller/Client
/Controller/Template

@tuj tuj merged commit 14d8d5f into os2display:release/3.0.0 Jun 30, 2025
22 of 23 checks passed
@tuj tuj deleted the feature/mono-repository branch June 30, 2025 09:34
@tuj tuj mentioned this pull request Jun 30, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants