Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a max buffer size? #219

Closed
dontlaugh opened this issue Jun 25, 2020 · 1 comment · Fixed by #220
Closed

Is there a max buffer size? #219

dontlaugh opened this issue Jun 25, 2020 · 1 comment · Fixed by #220
Labels
feature request

Comments

@dontlaugh
Copy link

Nice client!

I'm using tiny on a multi-user system in tmux, and i want to make sure I don't use an unbounded amount of memory if I just leave it open all day.
@osa1
Copy link
Owner

osa1 commented Jun 25, 2020

Thanks for the feedback!

We currently don't have this. This is actually quite easy to implement, the only reason why I haven't done so so far is because even though I leave my client running too (but not for months, in the worst case for a week or two, I think) I never see it using more than 0.1% or 0.2% of memory on my system.

For leaving it running for months on a multi-user system I agree that it might be useful and even necessary.

We can also easily make this configurable (e.g. max lines to keep in a tab).

Marking as "feature request". If anyone wants to implement I'd be happy to help. If not then I might do this myself this weekend.

trevarj added a commit to trevarj/tiny that referenced this issue Jun 25, 2020
@trevarj
Added optional config to limit the number of messages in each tab.
7626276 
Closes osa1#219.
@trevarj trevarj mentioned this issue Jun 25, 2020
Merged
trevarj added a commit to trevarj/tiny that referenced this issue Jun 26, 2020
@trevarj
Added optional config to limit the number of messages in each tab.
e739d75 
Closes osa1#219.

Added check if the max buffer was set to zero

Fixed up comments

Pull request feedback

Initial line buffer capacity fix
@osa1 osa1 closed this as completed in #220 Jun 26, 2020
osa1 pushed a commit that referenced this issue Jun 26, 2020
@trevarj
Added optional config to limit the number of messages in each tab (#220)
3e4ff0e 
Closes #219
osa1 added a commit that referenced this issue Jun 26, 2020
@osa1
Update changelog for #219
8a340be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added optional config to limit the number of messages in each tab. trevarj/tiny
2 participants
@osa1 @dontlaugh