We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: when /ignore is enabled, tabs should not change color on the joining or parting of a user
This is my fault, I think. When I added the JoinOrPart tab style I didn't check this scenario.
JoinOrPart
It comes from these two identical lines in conn.rs :
conn.rs
ui.set_tab_style(TabStyle::JoinOrPart, &MsgTarget::Chan { serv, chan: &chan })
Doesn't look like there's a way to get the ignore from there without adding another function on ui, so you could probably change it here in tui.rs:
ui
tui.rs
pub(crate) fn set_tab_style(&mut self, style: TabStyle, target: &MsgTarget) { self.apply_to_target(target, &|tab: &mut Tab, is_active: bool| { if !is_active && tab.style < style { tab.set_style(style); } }); }
The text was updated successfully, but these errors were encountered:
Good catch @trevarj . I think you're right that set_tab_style is where we fix this.
set_tab_style
Sorry, something went wrong.
Join/part tab style still worked with /ignore enabled
a610ce3
Closes osa1#291
3222b41
Closes #291
Successfully merging a pull request may close this issue.
Problem: when /ignore is enabled, tabs should not change color on the joining or parting of a user
This is my fault, I think. When I added the
JoinOrPart
tab style I didn't check this scenario.It comes from these two identical lines in
conn.rs
:Doesn't look like there's a way to get the ignore from there without adding another function on
ui
, so you could probably change it here intui.rs
:The text was updated successfully, but these errors were encountered: