-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tab_joinpart and SASL external to default config #412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added a small comment.
@@ -40,6 +42,7 @@ servers: | |||
# sasl: | |||
# username: tiny_user | |||
# password: hunter2 | |||
# pem: "/home/user/.config/tiny/oftc.pem" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also clarify somewhere (maybe right above the sasl:
line) that you either need pem
or username
+ password
? Currently it looks like you need all of them if you want to use SASL authentication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to make this clear with Choose only one of the options below.
in the general sasl description at the top. But maybe I should rephrase somehow..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose only one of the options below. -> Choose either username
and password
or pem
in the section below.
crates/tiny/config.yml
Outdated
@@ -29,6 +29,9 @@ servers: | |||
# | |||
# - `pass`: Sends `PASS` IRC command when connecting. | |||
# - `sasl`: For SASL authentication. | |||
# You can either authenticate using a password or use a certificate | |||
# with SASL EXTERNAL. Choose either `username` and `password` _or_ `pem` | |||
# in the section below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we're talking about sasl
section already we should drop the "in the section below" part because it may sound like there are two sections (the sasl
section + "the section below").
Alternatively we could also move this part right above the sasl:
line.
Thanks again! |
So that users can easily find the option to tweak it.
Related to #262 c6d20b6 introduced this option.