-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a data lifetime test #136
Conversation
@ChaitanayaKulkarni Please help with reviewing the first patch in this series. @kawasaki Do you get notified automatically if a pull request is created or do we perhaps have to ping you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new feature is interesting, thanks. Please find my review comments. Also, please fix "scsi/097" in the commit title.
de79585
to
63b5eb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the commits. I would like to clarify a few more points before merging the commits. Please find my review comments. If you are busy, I can edit the commit based on your comments.
tests/scsi/008
Outdated
# For patch "Fall back to F_SET_RW_HINT if F_SET_FILE_RW_HINT is not | ||
# supported" | ||
# (https://github.com/axboe/fio/commit/0cfea592fedf0011e695a604a6961e9cbc1fe9b6). | ||
_have_fio_ver 3 33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant "3 37", not "3 33".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for having reported this. This has been fixed.
Make _run_fio() return the fio exit code such that tests can use that exit code to verify whether or not a fio run completed successfully. Fixes: 3891768 ("blktests: add fio data verification routine") Signed-off-by: Bart Van Assche <bvanassche@acm.org>
SCSI disk data lifetime support is available since kernel v6.9-rc1. See also https://lore.kernel.org/linux-scsi/3b789eacddd6265921be9da6e15257908f29b186.camel@HansenPartnership.com/. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
63b5eb0
to
35b67ba
Compare
@bvanassche Thanks for the update. Have merged this PR. |
No description provided.