Skip to content

Commit

Permalink
Improve debuginfo warning
Browse files Browse the repository at this point in the history
Rather than the indirect link between verbage in the docs and getting
dependencies, just include the URL. Indent the related modules for
clarity.

Signed-off-by: Alex Gartrell <alexgartrell@gmail.com>
  • Loading branch information
alexgartrell committed Oct 18, 2023
1 parent 49971c9 commit 3c131d0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion libdrgn/debug_info.c
Original file line number Diff line number Diff line change
Expand Up @@ -336,11 +336,13 @@ drgn_debug_info_report_error(struct drgn_debug_info_load_state *load,
}
if (load->num_errors == 0 &&
!string_builder_append(&load->errors,
"could not get debugging information for:"))
"missing some debugging symbols (see https://drgn.readthedocs.io/en/latest/getting_debugging_symbols.html):"))
goto err;
if (load->num_errors < load->max_errors) {
if (!string_builder_line_break(&load->errors))
goto err;
if (!string_builder_append(&load->errors, " "))
goto err;
if (name && !string_builder_append(&load->errors, name))
goto err;
if (name && (message || err) &&
Expand Down

0 comments on commit 3c131d0

Please sign in to comment.