Skip to content

Commit

Permalink
cli: Open /proc/kcore via sudo when not root
Browse files Browse the repository at this point in the history
Non-root users can now run Drgn against the running kernel. Drgn will
attempt to use sudo to open /proc/kcore and transmit the opened file
descriptor back to the user process. The file descriptor is then passed
to Program.set_core_dump(). The user must still have sudo privileges.

Signed-off-by: Stephen Brennan <stephen@brennan.io>
  • Loading branch information
brenns10 authored and osandov committed Sep 11, 2023
1 parent 1c473bd commit 40c0831
Show file tree
Hide file tree
Showing 2 changed files with 76 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drgn/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import drgn
from drgn.internal.rlcompleter import Completer
from drgn.internal.sudohelper import open_via_sudo

__all__ = ("run_interactive", "version_header")

Expand Down Expand Up @@ -264,7 +265,10 @@ def _main() -> None:
elif args.pid is not None:
prog.set_pid(args.pid or os.getpid())
else:
prog.set_kernel()
try:
prog.set_kernel()
except PermissionError:
prog.set_core_dump(open_via_sudo("/proc/kcore", os.O_RDONLY))
except PermissionError as e:
print(e, file=sys.stderr)
if args.pid is not None:
Expand Down
71 changes: 71 additions & 0 deletions drgn/internal/sudohelper.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
# Copyright (c) Stephen Brennan <stephen@brennan.io>
# SPDX-License-Identifier: LGPL-2.1-or-later

"""Helper for opening a file as root and transmitting it via unix socket"""
import array
import os
from pathlib import Path
import pickle
import socket
import subprocess
import sys
import tempfile
from typing import Union


def open_via_sudo(
path: Union[Path, str],
flags: int,
mode: int = 0o777,
) -> int:
"""Implements os.open() using sudo to get permissions"""
# Currently does not support dir_fd argument
with tempfile.TemporaryDirectory() as td:
sockpath = Path(td) / "sock"
with socket.socket(socket.AF_UNIX, socket.SOCK_DGRAM) as sock:
sock.bind(str(sockpath))
subprocess.check_call(
[
"sudo",
sys.executable,
"-B",
__file__,
sockpath,
path,
str(flags),
str(mode),
],
)
fds = array.array("i")
msg, ancdata, flags, addr = sock.recvmsg(
4096, socket.CMSG_SPACE(fds.itemsize)
)
for level, typ, data in ancdata:
if level == socket.SOL_SOCKET and typ == socket.SCM_RIGHTS:
data = data[: fds.itemsize]
fds.frombytes(data)
return fds[0]
raise pickle.loads(msg)


def main() -> None:
sockpath = sys.argv[1]
filename = sys.argv[2]
flags = int(sys.argv[3])
mode = int(sys.argv[4])

sock = socket.socket(socket.AF_UNIX, socket.SOCK_DGRAM)
sock.connect(sockpath)
try:
fd = os.open(filename, flags, mode)
fds = array.array("i", [fd])
sock.sendmsg(
[b"success"],
[(socket.SOL_SOCKET, socket.SCM_RIGHTS, fds)],
)
except Exception as e:
sock.sendmsg([pickle.dumps(e)])


if __name__ == "__main__":
main()

0 comments on commit 40c0831

Please sign in to comment.