Improvements to opening /proc/kcore via sudo #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not, we can print the original helpful error message we had instead of blowing up. Refactor our handling of PermissionError to allow this. Signed-off-by: Omar Sandoval <osandov@osandov.com>
It'll probably be helpful to users to know why drgn is asking for sudo permissions. Signed-off-by: Omar Sandoval <osandov@osandov.com>
|
@brenns10 mind taking a look at a couple of usability suggestions for the sudo opener? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of followups to #347: