helpers.linux.kernfs: add kernfs_children() and follow_symlinks support #449
Conversation
Add kernfs_children() to iterate all kernfs_node in children rb_tree. Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
Extend kernfs_walk() to support symlink. Signed-off-by: Kuan-Ying Lee <kuan-ying.lee@canonical.com>
| :param follow_symlinks: If follow_symlinks is ``False``, and the | ||
| last component of a path is a symlink, the function will | ||
| return ``struct kernfs_node *`` of the symbolic link. |
There was a problem hiding this comment.
Why only the last component?
I guess I don't know well enough whether there are cases where symlinks would be in the middle of a real kernfs path. So maybe it won't make a difference. It just seems reasonable to support it within the path too.
There was a problem hiding this comment.
That probably came from my description in #443. My intention was that internal symlinks are always followed, and the last one is controlled by the parameter, just like O_NOFOLLOW and the os module. I haven't read the code to see if there was a misunderstanding.
There was a problem hiding this comment.
Ok, back from vacation and read the code now. Yes, this needs to be changed to always follow symlinks that are not the last component.
| for child in rbtree_inorder_for_each_entry( | ||
| "struct kernfs_node", kn.dir.children.address_of_(), "rb" | ||
| ): | ||
| yield child |
There was a problem hiding this comment.
Minor simplification:
| for child in rbtree_inorder_for_each_entry( | |
| "struct kernfs_node", kn.dir.children.address_of_(), "rb" | |
| ): | |
| yield child | |
| return rbtree_inorder_for_each_entry( | |
| "struct kernfs_node", kn.dir.children.address_of_(), "rb" | |
| ) |
| :param follow_symlinks: If follow_symlinks is ``False``, and the | ||
| last component of a path is a symlink, the function will | ||
| return ``struct kernfs_node *`` of the symbolic link. |
There was a problem hiding this comment.
Ok, back from vacation and read the code now. Yes, this needs to be changed to always follow symlinks that are not the last component.
Add kernfs_children() to iterate over the children of a directory in kernfs.
Add support of follow_symlinks.