test: test both quay.io/centos-bootc/{centos,fedora}-bootc:{eln,stream9}
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
from
029977c
to
427b747
Compare
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
6 times, most recently
from
4e67b59
to
f9c5f6f
Compare
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
5 times, most recently
from
78d4c66
to
8d540f9
Compare
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
from
8d540f9
to
e3074f9
Compare
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
4 times, most recently
from
f2c3ac9
to
5f5f8c6
Compare
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
from
5f5f8c6
to
7cd7879
Compare
achilleas-k
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
LGTM. Minor nitpick: the commit message subject is a bit too long (by 5 chars).
Maybe it'll be both shorter and clearer if it read:
test: run tests with both fedora and centos images
test both quay.io/centos-bootc/centos-bootc:stream9 and quay.io/centos-bootc/fedora-bootc:eln
...
Test both `quay.io/centos-bootc/{centos,fedora}-bootc:{eln,stream9}`,
now that `bib` supports both fedora and centos bootc we need to start
testing both as part of the integration suite.
Note that not all combinations are tested to save time, it's a
tradeoff and trivial enough to tweak.
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
from
7cd7879
to
4386d5d
Compare
Excellent point - I updated the commit now following this suggestion. |
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
from
4231a51
to
76476b3
Compare
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
from
76476b3
to
23f5b13
Compare
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
2 times, most recently
from
73b63ed
to
560c5e5
Compare
We are running out of disk space on the GH runners so we need to be more aggressive about cleanups.
mvo5
force-pushed
the
buildroot-from-container-test-stream9
branch
from
560c5e5
to
9d8f2dc
Compare
achilleas-k
approved these changes
Feb 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Is this obsolete now? |
|
This is merged indirectly via #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
bibsupports both fedora and centos bootc we need to start testing both as part of the integration suite.