partitions: Switch aarch64 to GPT, fully deduplicate #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: osbuild#551 There was a fair amount of copy-paste even when we just had aarch64+x86_64, the addition of duplicate bootfs/rootfs definitions for ppc64le+s390x is a strong motivation to finally define shared constants. I also factored out a shared `const` with some comments for the disk UUID that will save someone some time wondering about it later (this textually but not logically conflicts with osbuild#568 but I think this makes sense to land first). Signed-off-by: Colin Walters <walters@verbum.org>
mvo5
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #551
There was a fair amount of copy-paste even when we just had aarch64+x86_64, the addition of duplicate bootfs/rootfs definitions for ppc64le+s390x is a strong motivation to finally define shared constants.
I also factored out a shared
constwith some comments for the disk UUID that will save someone some time wondering about it later (this textually but not logically conflicts with #568 but I think this makes sense to land first).