bib: remove usage of BootcLegacyDiskImage (for qemu-9.1)
#689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
force-pushed
the
qemu-9-fc41
branch
15 times, most recently
from
2967420 to
7abd07d
Compare
mvo5
force-pushed
the
qemu-9-fc41
branch
2 times, most recently
from
181f35e to
88b9e7a
Compare
|
Do you know if the fixed qemu package landed in the latest podman machine os? |
Not yet, it seems podman machine is still at "Fedora CoreOS 40.20241019.2.0" - but even with that merging this should not have any ill consequences, podman machien will not yet work (until it moves to coreos 41) but cross building on fedora 41 will start working and even with the old pipeline we cannot currently cross build because ostree-rs started using openat2 so both the old and the new pipelines are not working today. I could split this though and just merge the updated test and leave the old pipeline intact (not sure if that would be helpful though). |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
Stale
achilleas-k
force-pushed
the
qemu-9-fc41
branch
from
5ae322f to
5f0d4c1
Compare
|
Rebased and fixed the conflict. |
This commit enables bib to work with the qemu-9.1+openat2 patches as proposed in https://src.fedoraproject.org/rpms/qemu/pull-request/70. With the qemu-user-statuc-aarch64 rpm produced by `fedpkg mockbuild` from this package the cross-arch test build works again. ``` $ sudo PYTHONPATH=. pytest './test/test_build.py::test_image_boots[quay.io/centos-bootc/centos-bootc:stream9,raw,CentOS Stream 9 ({arch}),arm64]' -s -vv ============================= test session starts ============================== platform linux -- Python 3.12.7, pytest-7.4.3, pluggy-1.3.0 -- /usr/bin/python3 cachedir: .pytest_cache rootdir: /home/mvogt/devel/osbuild/bootc-image-builder configfile: pytest.ini plugins: repeat-0.9.3, xdist-3.5.0 collected 1 item test/test_build.py::test_image_boots[quay.io/centos-bootc/centos-bootc:stream9,raw,CentOS Stream 9 ({arch}),arm64] [1/2] STEP 1/9: FROM registry.fedoraproject.org/fedora:40 AS builder ... PASSEDChecking disk usage for /var/tmp/bib-tests/shared0/68b20145da2cd3f2/image/disk.raw NOTE: disk usage after /var/tmp/bib-tests/shared0/68b20145da2cd3f2/image/disk.raw: 712472.71936 / 1998694.907904 Untagged: quay.io/centos-bootc/centos-bootc:stream9 Deleted: 0de1f90b11cbe7e2768101f6c55b4dd9841c13a2f87c8d9c177aea74ade88050 ============================= slowest 10 durations ============================= 1033.54s setup test/test_build.py::test_image_boots[quay.io/centos-bootc/centos-bootc:stream9,raw,CentOS Stream 9 ({arch}),arm64] 67.62s call test/test_build.py::test_image_boots[quay.io/centos-bootc/centos-bootc:stream9,raw,CentOS Stream 9 ({arch}),arm64] 2.30s teardown test/test_build.py::test_image_boots[quay.io/centos-bootc/centos-bootc:stream9,raw,CentOS Stream 9 ({arch}),arm64] ======================== 1 passed in 1103.58s (0:18:23) ======================== ```
This commit adds the https://launchpad.net/~mvo/+archive/ubuntu/qemu/ PPA that contains a backport of the openat2 patches for qemu-9 so that we can test cross-arch building again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables bib to work with the qemu-9.1+openat2 patches as proposed in https://src.fedoraproject.org/rpms/qemu/pull-request/69.
With the qemu-user-statuc-aarch64 rpm produced by
fedpkg mockbuildfrom this package the cross-arch test build works again.This will also re-enable the cross-arch test via an updated qemu-user-static (same patches for the GH runners as we use for the f41 rpm packages of qemu)