Two refactoring patches, validation of entrypoint state #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What I actually was going to fix is detecting |
cgwalters
force-pushed
the
entrypoint-go
branch
from
9c6f13a to
3ff1619
Compare
|
Only lightly tested locally so far...doing some more |
cgwalters
changed the title
|
OK now with some logic to validate that we're not running rootless, etc. |
mvo5
previously approved these changes
Jan 8, 2024
cgwalters
force-pushed
the
entrypoint-go
branch
from
c1625af to
cfeeb31
Compare
|
OK resolved all the nits except one |
achilleas-k
previously requested changes
Jan 9, 2024
cgwalters
force-pushed
the
entrypoint-go
branch
from
af81edc to
9d39e4d
Compare
mvo5
previously approved these changes
Jan 10, 2024
In the future it will very likely be useful for us to have other verbs. For now, this is effectively an implementation detail though because the entrypoint is changed to always pass `build`. (Actually right now this fixes the problem that the `completion` verb was being masked) Signed-off-by: Colin Walters <walters@verbum.org>
It's just ugly to have bits of this in shell script in this way; it's not complex code and doing it in Go helps keep the development environment simpler. Signed-off-by: Colin Walters <walters@verbum.org>
For functional clarity. Signed-off-by: Colin Walters <walters@verbum.org>
As this is a footgun that multiple people have run into. Signed-off-by: Colin Walters <walters@verbum.org>
In most cases e.g. we do want to show stdout/stderr, and it's handy to have a debug log when we're running a subprocess. While we're here, switch to just forking `cp` in the setup code. Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: Colin Walters <walters@verbum.org>
Per style.
achilleas-k
force-pushed
the
entrypoint-go
branch
from
a2ef51a to
0dd9197
Compare
|
Clicked the rebase button to get the |
|
@achilleas-k I think to merge you need to change your review state to approval |
achilleas-k
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move build logic into
buildsub-command verbIn the future it will very likely be useful for us to have
other verbs. For now, this is effectively an implementation
detail though because the entrypoint is changed to always pass
build.(Actually right now this fixes the problem that the
completionverb was being masked)
Move
prepare.shinto Go codeIt's just ugly to have bits of this in shell script in this
way; it's not complex code and doing it in Go helps keep
the development environment simpler.
Move some helpers into modules
For functional clarity.
Validate that we're in rootful podman
As this is a footgun that multiple people have run into.
Validate that we're running privileged
On general principle.