Wizard: LOCALE - Add Languages drop down (HMS-5151) #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2652 +/- ##
==========================================
+ Coverage 84.82% 85.14% +0.32%
==========================================
Files 172 173 +1
Lines 19625 20062 +437
Branches 1928 1945 +17
==========================================
+ Hits 16647 17082 +435
- Misses 2956 2958 +2
Partials 22 22
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
regexowl
changed the title
lucasgarfield
force-pushed
the
locale-languages-dropdown
branch
from
d603dfb to
d7ddb4f
Compare
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [filterValue]); | ||
|
|
||
| const sortfn = (a: string, b: string) => { |
There was a problem hiding this comment.
Need to update this so it uses the reusable utility function. Will take care of it tomorrow.
There was a problem hiding this comment.
Added a commit for the reusable function, thank you!
regexowl
force-pushed
the
locale-languages-dropdown
branch
from
d7ddb4f to
b8c79b8
Compare
regexowl
force-pushed
the
locale-languages-dropdown
branch
from
b8c79b8 to
5f4dbda
Compare
regexowl
force-pushed
the
locale-languages-dropdown
branch
from
5f4dbda to
de4c408
Compare
This adds a drop down for languages selection. The options are populated with an ouput of `localectl list-locales` and sorted to display results starting with the search term first. Also added tests.
This replaces sortfn with a reusable sorting function from utilities.
lucasgarfield
force-pushed
the
locale-languages-dropdown
branch
from
de4c408 to
d653b28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on #2651
This adds a drop down for languages selection. The options are populated with an ouput of
localectl list-localesand sorted to display results starting with the search term first.Also added tests.