Wizard: Add services to Review step (HMS-5404) #2806
Conversation
|
/jira-epic HMS-5371 |
schutzbot
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2806 +/- ##
==========================================
+ Coverage 82.31% 82.35% +0.04%
==========================================
Files 205 205
Lines 23004 23058 +54
Branches 2258 2267 +9
==========================================
+ Hits 18935 18989 +54
Misses 4042 4042
Partials 27 27
Continue to review full report in Codecov by Sentry.
|
regexowl
force-pushed
the
services-on-review
branch
2 times, most recently
from
915dc66 to
159a12c
Compare
regexowl
force-pushed
the
services-on-review
branch
from
159a12c to
1cd1029
Compare
| @@ -447,6 +452,23 @@ const Review = ({ snapshottingEnabled }: { snapshottingEnabled: boolean }) => { | |||
| <FirewallList /> | |||
| </ExpandableSection> | |||
| )} | |||
| {isServicesStepEnabled && ( | |||
There was a problem hiding this comment.
For firewall, we are checking length of the ports, disabled and enabled services, so that we do not see firewall expandable in case it is both empty. I suggest we do the same here, what do you think?
There was a problem hiding this comment.
So instead, can we do something like
| {isServicesStepEnabled && ( | |
| {isServicesStepEnabled && | |
| (services.enabled.length > 0 && services.disabled.length > 0) && |
There was a problem hiding this comment.
Aah, yeah. Forgot 😳 the check is there now! Thanks!
regexowl
force-pushed
the
services-on-review
branch
from
1cd1029 to
8e94145
Compare
regexowl
force-pushed
the
services-on-review
branch
2 times, most recently
from
77d3b72 to
77d160a
Compare
This adds systemd services expandable to the Review step.
regexowl
force-pushed
the
services-on-review
branch
from
77d160a to
38166fa
Compare
This adds systemd services expandable to the Review step.
JIRA: HMS-5404