Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Gate services on OpenSCAP step behind flag (HMS-5406) #2808

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 28, 2025

This gates the visibility of services on the OpenSCAP step behing a flag.

JIRA: HMS-5406

@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5371

@schutzbot schutzbot changed the title Wizard: Remove services from OpenSCAP step Wizard: Remove services from OpenSCAP step (HMS-5406) Jan 28, 2025
@regexowl regexowl force-pushed the remove-services-from-oscap-step branch 3 times, most recently from 157bea4 to d264221 Compare January 28, 2025 09:58
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (5b62598) to head (214d7a0).
Report is 3 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2808      +/-   ##
==========================================
+ Coverage   82.14%   82.16%   +0.01%     
==========================================
  Files         207      207              
  Lines       23181    23203      +22     
  Branches     2274     2275       +1     
==========================================
+ Hits        19042    19064      +22     
  Misses       4112     4112              
  Partials       27       27              
Files with missing lines Coverage Δ
...mageWizard/steps/Oscap/OscapProfileInformation.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d969646...214d7a0. Read the comment docs.

@regexowl regexowl force-pushed the remove-services-from-oscap-step branch from d264221 to a6b6c34 Compare February 4, 2025 14:23
@regexowl regexowl marked this pull request as ready for review February 4, 2025 14:24
@regexowl regexowl force-pushed the remove-services-from-oscap-step branch 5 times, most recently from ef9e91b to d13ea8d Compare February 7, 2025 09:38
@regexowl regexowl marked this pull request as draft February 7, 2025 14:02
@regexowl regexowl force-pushed the remove-services-from-oscap-step branch from d13ea8d to 62edaf5 Compare February 7, 2025 14:09
@regexowl regexowl changed the title Wizard: Remove services from OpenSCAP step (HMS-5406) Wizard: Gate services on OpenSCAP step behind flag (HMS-5406) Feb 7, 2025
@regexowl regexowl force-pushed the remove-services-from-oscap-step branch from da885d7 to e09fd9c Compare February 7, 2025 14:13
@regexowl regexowl marked this pull request as ready for review February 7, 2025 14:14
@regexowl regexowl force-pushed the remove-services-from-oscap-step branch from e09fd9c to 6b2d4be Compare February 7, 2025 14:21
This gates the visibility of services on the OpenSCAP step behing a flag.
This gates the visibility of kernel information behind a flag on the OpenSCAP step.
@regexowl regexowl force-pushed the remove-services-from-oscap-step branch from 6b2d4be to 214d7a0 Compare February 7, 2025 14:22
Copy link
Collaborator

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mgold1234 mgold1234 merged commit ac725f3 into osbuild:main Feb 7, 2025
19 of 20 checks passed
@regexowl regexowl deleted the remove-services-from-oscap-step branch February 10, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants