Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requestMapper: Fix snapshot date parsing (HMS-5463) #2853

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Feb 5, 2025

Regex was wrong, would take "2025-01-01T00:00:00.000Z" even though it's a valid RFC 3339 date.

JIRA: HMS-5463

@regexowl
Copy link
Collaborator Author

regexowl commented Feb 5, 2025

/jira-epic HMS-5279

@schutzbot schutzbot changed the title requestMapper: Fix snapshot date parsing requestMapper: Fix snapshot date parsing (HMS-5463) Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (874f6bd) to head (439f7e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nents/CreateImageWizard/utilities/requestMapper.ts 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2853      +/-   ##
==========================================
- Coverage   82.31%   82.31%   -0.01%     
==========================================
  Files         205      205              
  Lines       23008    23004       -4     
  Branches     2258     2258              
==========================================
- Hits        18939    18935       -4     
  Misses       4042     4042              
  Partials       27       27              
Files with missing lines Coverage Δ
...nents/CreateImageWizard/utilities/requestMapper.ts 94.85% <50.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 874f6bd...439f7e4. Read the comment docs.

Regex was wrong, would take "2025-01-01T00:00:00.000Z" even though it's a valid RFC 3339 date.
@regexowl regexowl force-pushed the fix-snapshot-date-format branch from e1d2c6d to 439f7e4 Compare February 6, 2025 07:58
@regexowl regexowl merged commit 5cc4791 into osbuild:main Feb 6, 2025
18 of 20 checks passed
@regexowl regexowl deleted the fix-snapshot-date-format branch February 6, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants