Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test hostname step on cockpit #2861

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

croissanne
Copy link
Member

Needed some mocks and minor tweaks, overall not too drastic of a change.

@croissanne croissanne force-pushed the cockpit-hostname-test branch from a8d6bed to e1f4304 Compare February 6, 2025 16:46
@croissanne croissanne changed the title test: add cockpit test for hostname step test: test hostae step on cockpit Feb 6, 2025
@croissanne croissanne changed the title test: test hostae step on cockpit test: test hostname step on cockpit Feb 6, 2025
@croissanne croissanne force-pushed the cockpit-hostname-test branch from e1f4304 to 26a1917 Compare February 6, 2025 16:56
@croissanne croissanne force-pushed the cockpit-hostname-test branch from 26a1917 to 2e8de1a Compare February 6, 2025 16:58
@regexowl
Copy link
Collaborator

regexowl commented Feb 7, 2025

/retest

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 46.15385% with 21 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (73afbc2) to head (2e8de1a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/test/mocks/cockpit/cockpitFile.ts 28.57% 10 Missing ⚠️
...t/Components/CreateImageWizard/wizardTestUtils.tsx 73.68% 5 Missing ⚠️
src/test/mocks/cockpit/index.ts 0.00% 3 Missing ⚠️
src/test/mocks/os-release/index.ts 0.00% 2 Missing ⚠️
src/Utilities/useGetEnvironment.ts 0.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2861      +/-   ##
==========================================
- Coverage   82.16%   82.14%   -0.03%     
==========================================
  Files         207      207              
  Lines       23155    23181      +26     
  Branches     2270     2274       +4     
==========================================
+ Hits        19026    19042      +16     
- Misses       4102     4112      +10     
  Partials       27       27              
Files with missing lines Coverage Δ
src/Utilities/useGetEnvironment.ts 50.00% <0.00%> (-1.43%) ⬇️
src/test/mocks/os-release/index.ts 12.50% <0.00%> (ø)
src/test/mocks/cockpit/index.ts 50.00% <0.00%> (-6.53%) ⬇️
...t/Components/CreateImageWizard/wizardTestUtils.tsx 96.06% <73.68%> (-2.70%) ⬇️
src/test/mocks/cockpit/cockpitFile.ts 18.18% <28.57%> (+7.92%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73afbc2...2e8de1a. Read the comment docs.

@regexowl regexowl enabled auto-merge (rebase) February 7, 2025 08:01
@regexowl regexowl merged commit 0624f4a into osbuild:main Feb 7, 2025
19 of 20 checks passed
@croissanne croissanne deleted the cockpit-hostname-test branch February 7, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants