-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RHINENG-15883): Add image-builder to new sentry flow #2880
base: main
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
@@ -55,26 +55,18 @@ if (process.env.NODE_ENV) { | |||
add_define('process.env.NODE_ENV', process.env.NODE_ENV); | |||
} | |||
|
|||
if (process.env.SENTRY_AUTH_TOKEN) { | |||
if (process.env.ENABLE_SENTRY) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is sentry already enabled on konflux by default? Or do we need to enable it ourselves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its defined in the sentry.yml file, a secret variable needs to be created and it set to true
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2880 +/- ##
==========================================
+ Coverage 82.14% 82.17% +0.02%
==========================================
Files 207 207
Lines 23220 23212 -8
Branches 2270 2270
==========================================
Hits 19074 19074
+ Misses 4119 4111 -8
Partials 27 27
Continue to review full report in Codecov by Sentry.
|
No description provided.