Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHINENG-15883): Add image-builder to new sentry flow #2880

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adonispuente
Copy link

No description provided.

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@adonispuente adonispuente marked this pull request as ready for review February 13, 2025 14:16
@@ -55,26 +55,18 @@ if (process.env.NODE_ENV) {
add_define('process.env.NODE_ENV', process.env.NODE_ENV);
}

if (process.env.SENTRY_AUTH_TOKEN) {
if (process.env.ENABLE_SENTRY) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is sentry already enabled on konflux by default? Or do we need to enable it ourselves?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its defined in the sentry.yml file, a secret variable needs to be created and it set to true

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (fceca8c) to head (7c174b1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
fec.config.js 0.00% 5 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
+ Coverage   82.14%   82.17%   +0.02%     
==========================================
  Files         207      207              
  Lines       23220    23212       -8     
  Branches     2270     2270              
==========================================
  Hits        19074    19074              
+ Misses       4119     4111       -8     
  Partials       27       27              
Files with missing lines Coverage Δ
fec.config.js 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fceca8c...7c174b1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants