Wizard: refactor HookValidatedInput component #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgold1234
force-pushed
the
refactor_fun
branch
2 times, most recently
from
40810b0 to
f385aea
Compare
…e field this commit split HookValidatedInput to 3 functions: useValidationState - manages validation state (isPristine, validated). TextAndTextAreaInput - use useValidationState and renders the TextInput or TextArea. ErrorMessage: displays validation error messages.
mgold1234
force-pushed
the
refactor_fun
branch
from
f385aea to
57b3ca3
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2922 +/- ##
==========================================
+ Coverage 82.09% 82.13% +0.03%
==========================================
Files 207 207
Lines 23291 23392 +101
Branches 2285 2306 +21
==========================================
+ Hits 19120 19212 +92
- Misses 4144 4153 +9
Partials 27 27
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit split
HookValidatedInputto 3 functions:useValidationState- manages validation state (isPristine, validated).TextAndTextAreaInput- use useValidationState and renders the TextInput or TextArea.ErrorMessage- displays validation error messages.check this split in userName filed