Dev Deps: Bump Jest to 29.4.1 #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps Jest to 29.4.1. This requires adding two additional development dependencies. As of Jest 28 `jest-environment-jsdom` is no longer shipped with Jest by default, and has therefore been added as a dependency. `uuid` was also added as a dev dependency. Jest 29 introduced some compatibility issues with `uuid` that were fixed in `uuid@9`: uuidjs/uuid#451 (comment) We import and use `uuid` in our tests, but as it was a dependencies dependency we did not control which version was installed. Version 8 (what was installed) causes Jest tests to fail like so: ``` SyntaxError: Unexpected token 'export' > 29 | import { v4 as uuidv4 } from 'uuid'; ```
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #952 +/- ##
=======================================
Coverage 76.00% 76.00%
=======================================
Files 61 61
Lines 1542 1542
Branches 384 384
=======================================
Hits 1172 1172
Misses 338 338
Partials 32 32 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit bumps Jest to 29.4.1. This requires adding two additional development dependencies.
As of Jest 28
jest-environment-jsdomis no longer shipped with Jest by default, and has therefore been added as a dependency.uuidwas also added as a dev dependency. Jest 29 introduced some compatibility issues withuuidthat were fixed inuuid@9: uuidjs/uuid#451 (comment)We import and use
uuidin our tests, but as it was a dependencies dependency we did not control which version was installed. Version 8 (what was installed) causes Jest tests to fail like so: