test: use importlib instead of imp #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
previously approved these changes
Sep 16, 2021
Merged
ondrejbudai
previously approved these changes
Sep 21, 2021
|
Ah, we need osbuild/osbuild-composer@95f8bd2 also here. |
atodorov
added a commit
to gicmo/koji-osbuild
that referenced
this pull request
Oct 4, 2021
atodorov
added a commit
to gicmo/koji-osbuild
that referenced
this pull request
Oct 4, 2021
See osbuild#62 (comment), osbuild/osbuild-composer@95f8bd2 Also requires to update the names of 8.4 runners.
atodorov
force-pushed
the
imp.importlib
branch
from
ab1d980 to
797dca2
Compare
Replace the usage of `imp` with `importlib` because the former is deprecated and newer pylint will complain and break CI.
See osbuild#62 (comment), osbuild/osbuild-composer@95f8bd2 Also requires to update the names of 8.4 runners.
atodorov
force-pushed
the
imp.importlib
branch
from
47b8459 to
37dc771
Compare
atodorov
approved these changes
Oct 5, 2021
ondrejbudai
approved these changes
Oct 5, 2021
ondrejbudai
pushed a commit
that referenced
this pull request
Oct 5, 2021
See #62 (comment), osbuild/osbuild-composer@95f8bd2 Also requires to update the names of 8.4 runners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the usage of
impwithimportlibbecause the former is deprecated and newer pylint will complain and break CI.