Support for oauth2 authentication #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croissanne
reviewed
Jan 19, 2022
croissanne
reviewed
Jan 19, 2022
This is so that we can add retry logic when doing SSO/OAuth2.
Implement support for authentication via OAuth2 using the client credentials "Client Credentials Grant" flow (4.4 of RFC 6749). For this a new configuration section is added to the config file, where the client_id, client_secret and token_url have to be specified. The impelmention does currently not support "refresh tokens", but does support refreshing the token if an `expires_in` is present in the token itself. Corresponding unit tests have been added. [1] https://datatracker.ietf.org/doc/html/rfc6749#section-4.4
Add a new helper script to run the mock open id server that is shipped inside the osbuild-composer-tests package.
Switch the authentication method that the koji builder plugin uses from mTLS to SSO. Since we are using the mock openid server from the `osbuild-composer-tests` package. Make this package a dependency of `koji-osbuild-tests`.
gicmo
force-pushed
the
oauth2
branch
2 times, most recently
from
29373b0 to
59dabbb
Compare
|
I added actual integration tests via the mock open id server provided by Open question, I called the configuration section From the logs, I am pretty sure we get a new instance of the plugin for every request so we should be fine concurrency-wise, but I might have to re-check the actual koji code. |
gicmo
force-pushed
the
oauth2
branch
3 times, most recently
from
a23d647 to
913a881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for authentication via OAuth2 using the client credentials "Client Credentials Grant" flow (4.4 of RFC 6749). For this a new configuration section is added to the config file, where the client_id, client_secret and token_url have to be specified.
The implementation does currently not support "refresh tokens", but does support refreshing the token if an
expires_inis present in the token itself.Corresponding unit tests have been added.