Update osbuild/images to v0.111.0 #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
update-api-for-pr1142
branch
from
5c03ec6 to
9d4d174
Compare
achilleas-k
force-pushed
the
update-api-for-pr1142
branch
from
9d4d174 to
d90c951
Compare
achilleas-k
changed the title
thozza
previously approved these changes
Jan 28, 2025
|
Lot of failures in CI and I don't think they're flakes. Looking into them. |
mvo5
force-pushed
the
update-api-for-pr1142
branch
from
d90c951 to
e089a2c
Compare
Update the weldr API to work with the new depsolve API. Update tests to match (adding repo_id). Co-authored-by: Achilleas Koutsou <achilleas@koutsou.net>
mvo5
force-pushed
the
update-api-for-pr1142
branch
from
b18c8e7 to
f9bb944
Compare
achilleas-k
approved these changes
Jan 29, 2025
|
Thank you so much @achilleas-k for helping with this one! |
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit: draft as I'm stuggeling right now with the weldr tests and the repo_id integration thereThis is a WIP branch to port osbuild-composer to the latest version of images. The notable change is the inclusion of the librepo support which changes the manifest.Serialize() API but it also adds extra fields like "repo_id" into the package spec.
EDIT (akoutsou): Fixed up the tests. Had to add repo IDs to a lot of mock responses. Some of them needed to be added by the test function separately because they change based on the repo config.