-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudapi: support worker server target result options #4574
Conversation
a008a41
to
4c0d71a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. There is one small issue, that may not really matter, but to save it locally you now need an entry in upload_targets
where before you could just set upload_options
on the image_request
. If you do that now it defaults to an S3 upload and then fails because it isn't setup -- but doesn't fail until the end. So we may want to add a check for this at some point.
"upload_targets": [
{
"type": "local",
"upload_options": {
"local_save": true
}
}
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The PR looks good in general. 👍
However, I do have a few nitpicks... 😇 Specifically, I'd like to request changes to the naming of the newly added struct member, so that it expresses what value it actually holds. IOW don't use "filename" if it holds relative or absolute paths to the artifact. We use "filename" when it is really just the name of the file.
4c0d71a
to
d4f0010
Compare
In order to get the artifact location from the cloudapi, add a helper function in the worker server.
The local target shouldn't require any specific configuration and should just be available always.
d4f0010
to
5592882
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adds results for the worker server target, the full path to the artefact. This is useful for cockpit-image-builder, which can then show the user the path to the image they have built in case they selected a local target.