Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Max Horn <max@quendi.de>
  • Loading branch information
sebasguts and fingolfin authored May 16, 2019
1 parent 25c7dd7 commit 46e73c0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions pkg/GAPJulia/JuliaInterface/julia/ccalls.jl
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ function ValueGlobalVariable( name :: String )
end

function CanAssignGlobalVariable(name::String)
ccall( :GAP_CanAssignGlobalVariable, Bool,
ccall(:GAP_CanAssignGlobalVariable, Bool,
(Ptr{UInt8},), name)
end

function AssignGlobalVariable(name::String, value::MPtr )
function AssignGlobalVariable(name::String, value::MPtr)
if ! CanAssignGlobalVariable(name)
error( "cannot assing to $name in GAP")
error("cannot assing to $name in GAP")
end
ccall( :GAP_AssignGlobalVariable, Cvoid,
ccall(:GAP_AssignGlobalVariable, Cvoid,
(Ptr{UInt8}, MPtr), name, value)
end

Expand Down
2 changes: 1 addition & 1 deletion pkg/GAPJulia/JuliaInterface/julia/gap.jl
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ function Display(x::MPtr)
AssignGlobalVariable(local_var,x)
xx = EvalStringEx("Display($local_var);")[1]
if xx[1] == true
println(GAP.gap_to_julia(AbstractString,xx[5]))
println(GAP.gap_to_julia(AbstractString, xx[5]))
else
error("variable was not correctly evaluated")
end
Expand Down

0 comments on commit 46e73c0

Please sign in to comment.