Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGES.md, prepare for 0.11.1 release #1000

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

fingolfin
Copy link
Member

No description provided.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (2cf157c) to head (56121c1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   75.78%   75.46%   -0.33%     
==========================================
  Files          51       50       -1     
  Lines        4204     4173      -31     
==========================================
- Hits         3186     3149      -37     
- Misses       1018     1024       +6     
Files Coverage Δ
src/macros.jl 93.58% <ø> (-1.29%) ⬇️

... and 10 files with indirect coverage changes

@lgoettgens
Copy link
Member

Maybe mention #991 as well?

@fingolfin
Copy link
Member Author

Indeed, I somehow overlooked it. Added and also improved the @wrap docstring a bit

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.
In particular term "convert to GapObj" in the description of functions created by @wrap fits better; note that this conversion means in fact "unwrapping" for many Oscar objects.

@fingolfin fingolfin merged commit 8597100 into oscar-system:master Jun 6, 2024
22 checks passed
@fingolfin fingolfin deleted the mh/changes branch June 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants