-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using JLLs #421
Switch to using JLLs #421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
===========================================
+ Coverage 38.11% 64.15% +26.04%
===========================================
Files 214 68 -146
Lines 31589 5343 -26246
===========================================
- Hits 12039 3428 -8611
+ Misses 19550 1915 -17635
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, however, I would have prefered to see the GAP banner, simply to see which version of GAP I am about to run:
$ $(julia -e 'import GAP; print(GAP.gap_exe())')
gap> 1+1;
2
This is really nice:
Is it possible to assign GAP.Globals.SESSION to an exported function called
|
That hypothetical |
5b9516c
to
7563da3
Compare
29d2392
to
2de8fcd
Compare
Note that this means we'll load an extra copy of the GMP for now. If this turns out to be a problem, I could drop the GMP_jll bit again.
This is not done; in particular, I am experimenting more with how to launch the GAP inside GAP.jl. Right now I am experimenting with just launching it via julia: In particular, instead of
$(julia -e 'import GAP; print(GAP.gap_exe())')
one can doimport GAP; GAP.Globals.SESSION()
to get a GAP prompt. This is missing a banner (easy to fix) and also doesn't handle command line arguments (slightly more work to fix, but doable)Fixes #415